Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 1.8 compatibility (Agent-side) #146

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Ruby 1.8 compatibility (Agent-side) #146

merged 1 commit into from
Jan 18, 2018

Conversation

sathieu
Copy link

@sathieu sathieu commented Jan 16, 2018

No description provided.

@tuxmea
Copy link
Member

tuxmea commented Jan 18, 2018

Ruby 1.8? Are you still running on Puppet 2.x?

@alexjfisher
Copy link
Member

@tuxmea Puppet 3 on RedHat/CentOS 6 systems were usually ruby 1.8.

But we don't support puppet 3 at all anymore, (since the begginning of last year IIRC), and dropped support for ruby 1.8 maybe a year before that.

@tuxmea tuxmea added the wont-fix This will not be worked on label Jan 18, 2018
@tuxmea
Copy link
Member

tuxmea commented Jan 18, 2018

@sathieu please read comment from @alexjfisher. voxpupuli skipped puppet 3 and ruby 1.8 support. consider upgrading to puppet 4 or 5.
Please reopen in case that you see an urgent need for ruby 1.8 support.

@tuxmea tuxmea closed this Jan 18, 2018
@sathieu
Copy link
Author

sathieu commented Jan 18, 2018

@tuxmea @alexjfisher Yes please reopen this PR. It is just a one line patch which fixes errors on our old servers (we have a dozen of those oldies, and yes upgrade is planned).

@tuxmea
Copy link
Member

tuxmea commented Jan 18, 2018

@sathieu reopened. can anybody else place his vote on this PR?
Looks good to me.

@tuxmea tuxmea reopened this Jan 18, 2018
@tuxmea tuxmea added needs-feedback Further information is requested and removed wont-fix This will not be worked on labels Jan 18, 2018
@alexjfisher
Copy link
Member

Because this is just a change to a fact and facts run on all hosts, I'm ok with this.
But... this wouldn't mean we support using the prometheus module on ruby 1.8 or puppet 3 systems.

@tuxmea tuxmea merged commit 424f17b into voxpupuli:master Jan 18, 2018
@sathieu sathieu deleted the ruby1.8 branch January 18, 2018 18:43
@sathieu
Copy link
Author

sathieu commented Jan 18, 2018

Thanks !

cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Aug 28, 2019
@tuxmea
Merge pull request voxpupuli#146 from sathieu/ruby1.8
bef1565 
Ruby 1.8 compatibility (Agent-side) - fact only. This does not mean that ruby 1.8 or older puppet versions are supported by this module.
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
@tuxmea
Merge pull request voxpupuli#146 from sathieu/ruby1.8
0921843 
Ruby 1.8 compatibility (Agent-side) - fact only. This does not mean that ruby 1.8 or older puppet versions are supported by this module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-feedback Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sathieu @tuxmea @alexjfisher