Fix Archive creates definition

[sc0rp10]

Because of typo, archive resource tries to uses directory like /opt/prometheus::redis_exporter-0.15.0.linux-amd64/prometheus::redis_exporter instead of /opt/redis_exporter-0.15.0.linux-amd64.

This was produced endless message

Notice: /Stage[main]/Prometheus::Redis_exporter/Archive[/tmp/redis_exporter-0.15.0.tar.gz]/creates: creates changed 'archive not extracted' to extracting in /opt/redis_exporter-0.15.0.linux-amd64 to create /opt/prometheus::redis_exporter-0.15.0.linux-amd64/prometheus::redis_exporter

I changed variable name to the correct one.

[bastelfreak]

Hi @sc0rp10, thanks for the fix. Can you add a test for this that verifies that it is working?

[sc0rp10]

@bastelfreak hi!
Unfortunately, i'm not experienced puppet developer, I can just copy-paste-replace =/
I try to learn how to write tests, but right now module is broken.
Should users wait for me?
I think fix without tests more important than broken code.
What do you think?

[dhollinger]

@sc0rp10 thanks for the PR.

We generally require tests for our PRs as we use those to validate that the fix/feature/enhancement actually does what is expected before we merge.

We are willing to provide help and guidance with the tests.

[blupman]

i think this issue was fixed in with pull request #215

[bastelfreak]

@sc0rp10 can you test against our master branch and check if the error is fixed for you?

[dhoppe]

@bastelfreak I agree with @blupman and this pull request should be closed, because of missing feedback.

[bastelfreak]

Did you add this on purpose or was it planned for the other PR. I think this change isn't related, so please undo it.

[sc0rp10]

ah sorry, my mistake

[bastelfreak]

Hi. I closed this PR. Please reopen it if you're still interested in it.