add varnish_exporter #171
Merged
add varnish_exporter #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @blupman, thanks for your PR. Can you please check the used email address in your commit? It isn't associated with your github account. |
|
Please also rebase against our latest master branch. #172 introduced some conflicts. |
|
Hi @bastelfreak Thanks for your feedback!, I have added my work email to the profile, also rebased, i took a few try's to figure out failing spectest on arch linux. |
|
Hi @bastelfreak I have updated varnish_exporter to reflect the recent changes done to the master branch. |
|
thanks @blupman ! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
add varnish_exporter
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
add varnish_exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used haproxy_exporter and rabbitmq_exporter to create varnish_exporter,
it installs https://github.com/jonnenauha/prometheus_varnish_exporter/ which seems to be a commonly used varnish_exporter