fix notify $service_name in the alertmanager #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
previously requested changes
Jun 25, 2018
|
My mistake. I see $notify_service is already a reference to the service resource. |
alexjfisher
dismissed
their stale review
$notify_service is either undef or Service[$service_name]
|
Thanks @thde ! |
bastelfreak
changed the title
|
@bastelfreak Any ideas when the newest version of the module will be released? I'm just impatient to get this fix 👍 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
fix notify service_name
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
fix notify service_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Fixes the alertmanager config file to notify the configured service.
This Pull Request (PR) fixes the following issues
n/a