Feature/collectd exporter #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Oct 17, 2018
manifests/collectd_exporter.pp
Outdated
| # The binary release version | ||
| # | ||
| class prometheus::collectd_exporter ( | ||
| String $download_extension, |
There was a problem hiding this comment.
for all strings, could you please switch to String[1]? That will enforce a minimal string length of one.
|
Thanks for the PR @mindriot88. Can you add an acceptance test to https://github.com/voxpupuli/puppet-prometheus/tree/master/spec/acceptance ? |
|
@bastelfreak I have addressed both your comments, let me know if you need further changes |
|
I restarted one travis job. it failed because of a network issue between travis and github. |
bastelfreak
added
enhancement
|
Thanks! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
Feature/collectd exporter
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Feature/collectd exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues