Update network denendency in daemon systemd template #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Sep 26, 2020
templates/daemon.systemd.erb
Outdated
| @@ -2,7 +2,7 @@ | |||
| [Unit] | |||
| Description=Prometheus <%= @name %> | |||
| Wants=basic.target | |||
| After=basic.target network.target | |||
| After=basic.target network-online.target | |||
There was a problem hiding this comment.
after some scrolling through https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/ I guess we should set:
After=network-online.target
Wants=network-online.target
?
There was a problem hiding this comment.
Sorry for the late reply. Yes, I think it's better.
There was a problem hiding this comment.
I just push an updated version. Please help to check, thanks.
bastelfreak
added
bug
The config for services in puppet-prometheus module listen on 0.0.0.0 by default. However, when config listens to private IP, services will fail to start because "After=network.target" doesn't ensure network interface up. It's safer to use "After=network-online.target" here
moonape1226
force-pushed
the
Update_network_dependency_in_daemon_systemd_template
branch
from
86f80b8 to
25ce4ac
Compare
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Mar 11, 2024
…ndency_in_daemon_systemd_template Update network denendency in daemon systemd template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The config for services in puppet-prometheus module listen on 0.0.0.0 by default. However, when config listens to private IP,
services will fail to start because "After=network.target" doesn't ensure network interface up. It's safer to use "After=network-online.target"
This Pull Request (PR) fixes the following issues
No issue has been filed for this PR.