(FACT-2880) fact: call Puppet within setcode block #511
Conversation
|
I tested this on Facter 3 and Facter 4, both work fine. I'm still waiting for feedback in https://tickets.puppetlabs.com/browse/FACT-2880 if this should be changed or if it's only a workaround for Facter 4. |
This change is a result of https://tickets.puppetlabs.com/browse/FACT-2880 previous to this change, we called Puppet outside the setcode block. This works fine on Facter 3. On Facter 4 this sets the service_provider fact to `base`. Moving the code into the setcode block fixes it.
|
okay, turns out it should always be in the setcode |
|
Is there an ETA for the next release to include this PR? |
|
mhm tricky. we already have backwards incompatible changes merged to master. to reduce the amount of major releases I would like to include more of those changes, for example updating the exporters to latest version. If you would like to help that would be awesome. Most of the versions are listed in https://github.com/voxpupuli/puppet-prometheus/blob/master/data/defaults.yaml . they need to be updated to their latest version and the related acceptance tests in https://github.com/voxpupuli/puppet-prometheus/tree/master/spec/acceptance should be updated to match the new version. |
This change is a result of https://tickets.puppetlabs.com/browse/FACT-2880
previous to this change, we called Puppet outside the setcode block.
This works fine on Facter 3. On Facter 4 this sets the service_provider
fact to
base. Moving the code into the setcode block fixes it.Pull Request (PR) description
This Pull Request (PR) fixes the following issues