Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert daemon.env template to EPP #529

Merged
merged 1 commit into from
Feb 23, 2021
Merged

convert daemon.env template to EPP #529

merged 1 commit into from
Feb 23, 2021

Conversation

anarcat
Copy link

@anarcat anarcat commented Feb 23, 2021

Should be a noop

@anarcat anarcat mentioned this pull request Feb 23, 2021
Merged
@anarcat
Copy link
Author

anarcat commented Feb 23, 2021

note that because of the stricter EPP syntax, this might break third-party use of the env_vars invocation. they would need to do something kind of weird though, to pass something other than a String key or String/Int value... so i'm not sure it's that big of a concern.

also, yikes, sorry, i fixed the test suite here, i think.

@anarcat anarcat merged commit 4e1d90c into voxpupuli:master Feb 23, 2021
@anarcat anarcat deleted the daemon-env-epp branch February 23, 2021 22:28
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Mar 11, 2024
@anarcat
Merge pull request voxpupuli#529 from anarcat/daemon-env-epp
2aef2d7 
convert daemon.env template to EPP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anarcat @bastelfreak