Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation conflicts itself on whether or not pip must be explictly specified. #160

Closed
stkerr opened this issue Dec 16, 2014 · 6 comments
Closed

Documentation conflicts itself on whether or not pip must be explictly specified. #160

stkerr opened this issue Dec 16, 2014 · 6 comments
Assignees
@stankevich

Comments

@stkerr
Copy link

stkerr commented Dec 16, 2014

Both of these are specified:

"You must explicitly specify pip => true in the python class if you want pip installed. As such, the pip package is now independent of the dev package and so one can exist without the other."

"pip - Install python-pip. Default: true"
@gene1wood
Copy link
Contributor

It looks like based on the code that the error is with the first documentation string.

Code for default : https://github.com/stankevich/puppet-python/blob/09967704c152f5fd044ed4ddbc7382ef2e24aea5/manifests/params.pp#L7

@shivapoudel
Copy link
Contributor

@gene1wood will you be interested in PR for this documentation fix :)

gene1wood added a commit to gene1wood/puppet-python that referenced this issue Jul 21, 2015
@gene1wood
Update docs to reflect current pip parameter default and move release…
447c671 
… notes to the bottom of the page.

Since the release notes reflect changes from long in the past it's probably confusing to have them at the very top of the page. I've moved them to the bottom to reflect the fact that they are not as important as the installation and usage instructions.
Fixes voxpupuli#160
@gene1wood gene1wood mentioned this issue Jul 21, 2015
Merged
@gene1wood
Copy link
Contributor

Sure thing. I've added PR #217 but it says there are branch conflicts. I've not seen a conflict message like this before and I'm unsure what needs to be done to resolve it.

@gene1wood
Copy link
Contributor

Also @shivapoudel you closed this issue after you commented asking for a PR (which may have been on accident)

@gene1wood
Copy link
Contributor

Disregard my branch conflict comment, I got confused and have fixed it.

@shivapoudel
Copy link
Contributor

Thank! I have merged #217 🎉

shivapoudel pushed a commit that referenced this issue Sep 1, 2015
@gene1wood
Update docs to reflect current pip parameter default and move release…
c2f3c16 
… notes to the bottom of the page.

Since the release notes reflect changes from long in the past it's probably confusing to have them at the very top of the page. I've moved them to the bottom to reflect the fact that they are not as important as the installation and usage instructions.
Fixes #160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stankevich stankevich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stkerr @gene1wood @stankevich @shivapoudel