Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip install runs every time for packages with underscores in the name #258

Closed
rpocase opened this issue Oct 30, 2015 · 4 comments
Closed

pip install runs every time for packages with underscores in the name #258

rpocase opened this issue Oct 30, 2015 · 4 comments

Comments

@rpocase
Copy link
Contributor

rpocase commented Oct 30, 2015

Pip freeze replaces underscores in package names with with hyphens. The grep regex does not take this into account, so it will always try to install packages with underscores in the package name.

E.g, for websocket_client
$pip freeze
websocket-client==0.32.0

Package name needs to have underscores replaced with hyphens when used in $grep_regex in pip.pp.
@igalic
Copy link
Contributor

igalic commented Nov 7, 2015

that's kinda tricky, because it also means modifying the namevar… in a way…

@rpocase
Copy link
Contributor Author

rpocase commented Nov 7, 2015

I've got a fix on our local module that I think is pretty safe. I keep meaning to do a pull request. I'll try and get that done this weekend.

rpocase added a commit to rpocase/puppet-python that referenced this issue Nov 9, 2015
@rpocase
Addressing stankevich/puppet-python issue voxpupuli#258.
cf153cb 
Updating grep regex to use package name with underscores
replaced with hyphens.
@rpocase rpocase mentioned this issue Nov 9, 2015
Merged
shivapoudel pushed a commit that referenced this issue Nov 9, 2015
Merge pull request #260 from rpocase/master
cbb5c8b 
Addressing stankevich/puppet-python issue #258.
@rpocase rpocase closed this as completed Nov 10, 2015
adamcstephens pushed a commit to covermymeds/puppet-python that referenced this issue Jan 19, 2016
@rpocase
Addressing stankevich/puppet-python issue voxpupuli#258.
2f0a591 
Updating grep regex to use package name with underscores
replaced with hyphens.
@rpocase
Copy link
Contributor Author

rpocase commented Feb 8, 2017

@igalic It looks like this got reintroduced in the next commit. Any chance of a new merge with this fix?

@gdubicki
Copy link
Member

gdubicki commented Sep 4, 2017

Thanks for catching this, @rpocase . Can you please reopen this ticket as a contributor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@igalic @gdubicki @rpocase