new manage_requirements argument to address issue 273 #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(My first ever pr; please be gentle...) |
|
@rosenbergj thanks for contributing! |
| @@ -38,6 +38,9 @@ | |||
| # [*extra_pip_args*] | |||
| # Extra arguments to pass to pip after the requirements file | |||
| # | |||
| # [*manage_requirements*] | |||
There was a problem hiding this comment.
This also needs to be documented in the README.md
rosenbergj
force-pushed
the
issue-273
branch
2 times, most recently
from
f2d5e72
to
42afd0d
Compare
|
Looks good. We also need some spec tests - See https://github.com/stankevich/puppet-python/blob/master/spec/defines/requirements_spec.rb Add a block where you let params set manage_requirements to false and it should test that the file context "/requirements.txt" do
let (:params) {{ :requirements => "/requirements.txt", :manage_requirements => false }}
it { is_expected.not_to contain_file("/requirements.txt") }
end |
shivapoudel
pushed a commit
that referenced
this pull request
Dec 15, 2015
new manage_requirements argument to address issue 273
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.