Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sinatra gem required for PE webhook? #154

Closed
esalberg opened this issue Apr 16, 2015 · 4 comments
Closed

Sinatra gem required for PE webhook? #154

esalberg opened this issue Apr 16, 2015 · 4 comments
Labels
bug Something isn't working

Comments

@esalberg
Copy link

Is there a reason that the gem install for sinatra is only in the non-PE section of webhook.pp? I can put in a pull request to add it (we don't have sinatra defined already, so it errors out with a dependency check), but I wanted to make sure that sinatra was still supposed to be a dependency for the PE webhook first.
@acidprime
Copy link
Collaborator

@esalberg good catch , please update the ticket if you still have any issues.

@acidprime acidprime added the bug Something isn't working label Apr 20, 2015
@esalberg
Copy link
Author

I think the package needs to use the pe_gem provider instead of the gem provider (for Puppet Enterprise)?

My master is erroring with:
2015-04-22 13:53:31 -0400 /Packagesinatra: Provider gem is not functional on this host

acidprime pushed a commit that referenced this issue Apr 22, 2015
Fix #154
36d3075 
Prior to this commit we moved the declaration in from
acidprime@46b8a3b
but that caused issues as this needs to use a different provider
for each type of installation. Currenly this logic is not passed in via the main
class in the interim I am adding two resources with the different values.
@acidprime
Copy link
Collaborator

@esalberg released a fix in 2.7.3

@esalberg
Copy link
Author

Looks good! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acidprime @esalberg