Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Error in voxpupuli/puppet-r10k/templates/webhook.bin.erb, line 119 #427

Closed
djconn-ncsu opened this issue Apr 30, 2018 · 1 comment · Fixed by #428
Closed

Syntax Error in voxpupuli/puppet-r10k/templates/webhook.bin.erb, line 119 #427

djconn-ncsu opened this issue Apr 30, 2018 · 1 comment · Fixed by #428

Comments

@djconn-ncsu
Copy link

djconn-ncsu commented Apr 30, 2018

There is a syntax Error in voxpupuli/puppet-r10k/templates/webhook.bin.erb, line 119

The line
$logger.info("Deploying module #{module_name}" in the background.)
should be
$logger.info("Deploying module #{module_name} in the background.")

Basically, the end of string double-quote is in the wrong place.

Affected Puppet, Ruby, OS and module versions/distributions

I believe this would affect all versions, but I'm running RHEL 7.

How to reproduce (e.g Puppet code you use)

Any attempt to commit code to a GitHub branch being watched by Webhook causes this problem.

What are you seeing

systemctl list-units --failed
  UNIT            LOAD   ACTIVE SUB    DESCRIPTION
● webhook.service loaded failed failed R10K Webhook Service
journalctl -u webhook.service
Apr 27 16:06:05 myhost.blah.blah webhook[52019]: /usr/local/bin/webhook:110: syntax error, unexpected keyword_in, expecting ')'
Apr 27 16:06:05 myhost.blah.blah webhook[52019]: $logger.info("Deploying module #{module_name}" in the background.)
Apr 27 16:06:05 myhost.blah.blah webhook[52019]: ^
Apr 27 16:06:05 myhost.blah.blah webhook[52019]: /usr/local/bin/webhook:110: syntax error, unexpected ')', expecting '('

What behaviour did you expect instead

Output log

Any additional information you'd like to impart

rnelson0 added a commit that referenced this issue May 1, 2018
@rnelson0
Copy link
Member

rnelson0 commented May 1, 2018

This fix will be in 6.5.1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants