use stdlib puppet facts for configuration #352
Conversation
|
This broke all the tests. Can you review the failures to see what the fix is? |
|
As far as I can tell, all failures have nothing to do with my change, seems Travis environment is broken to begin with. |
|
The errors are definitely related to your changes, they have to do with r10k_basedir. It's expecting an actual path and getting something else. It may be a missing fact or it may need to change the data type. I suggest rebasing on master first, though, there has been a modulesync since this was submitted. |
|
I will be first one to admit I am bad with tests. I presume the problem is, actual puppet is not running there, so facts are not being collected. Do I add them to default_module_facts.yml ? |
|
Well, that didn't help :( |
|
I think you need to set the facts hash element directly, rspec-puppet doesn't normalize between global facts and the facts hash. |
|
How do I do this? |
|
From what I understand by reading spec/spec_helper.rb, it should load those facts |
|
I found this PR https://github.com/voxpupuli/puppet-selinux/pull/217/files |
|
@vchepkov Can you rebase on master? We updated with a modulesync recently, at the least that should make the test results easier to read. |
|
Done |
default_module_facts.yml
Outdated
| @@ -1,2 +1,4 @@ | |||
| --- | |||
| pe_version: '2016.4.1' | |||
| puppet_environmentpath: '/etc/puppetlabs/code/environments' | |||
| puppet_vardir: '/opt/puppetlabs/puppet/cache' | |||
There was a problem hiding this comment.
Shouldn't this file go in spec? That's where selinux puts it.
There was a problem hiding this comment.
I honestly don't know, I added to an existing file, I assumed it's in the right place
let me move it
puppetserver doesn't honor puppet.conf vardir settings
|
Much better now |
|
You can blame me for putting the file in the wrong spot :) Thanks! |
puppetserver doesn't honor puppet.conf vardir settings
This would solve #351