Manage puppet.conf's $modulepath #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 15, 2013 20:36
Previously, the R10k module didn't manage Puppet's Modulepath to point it to the Modules in the dynamic environments that were created. That step needed to be done out-of-band. This commit adds the ability to manage both FOSS and PE's $modulepaths via Puppet.conf and the inifile custom type.
Previously, the module was refactored to allow the modulepath to be declared using the inifile type. This commit moves the modulepath to be a parameter that can be passed for the main r10k class, thus making it tunable for anyone using the module.
Remove redundant $::is_pe check and clean up variables.
Previously I did a check in the config class for $::is_pe and set the modulepath that way. When I refactored, I forgot to remove that check and pass the $modulepath from the main r10k class. This commit fixes that.
Previously, a commit was entered to manage the $modulepath in puppet.conf. This commit introduces the ability to choose whether or not to manage the $modulepath by passing a boolean false value for the $manage_modulepath parameter to the r10k class. There is no boolean validation checking for this yet.
Puppet's declarative...until it isn't. Because Puppet's parser parses variables from top-to-bottom, variables must be declared before they're referenced, or else they have an empty/undefined value. This commit re-orders variables in the params class to fix potentially undefined variables.
acidprime
added a commit
that referenced
this pull request
Aug 23, 2013
Manage puppet.conf's $modulepath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a $modulepath parameter to the r10k module
so the $modulepath parameter in puppet.conf can be managed. It also introduces
$manage_modulepath as a way to opt-out of having the module manage the $modulepath.