Using #to_yaml instead of printing each element #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies the template for `r10k.yaml` to use the `#to_yaml` method to generate valid YAML data structures from the data passed to the template. Previously, we'd print each element assuming there would be no nested data structures. This PR allows nested data structures to be passed to `git_settings`, `forge_settings`, and `deploy_settings` parameters. DRYing out my code
danzilio
force-pushed
the
nested_configs
branch
from
141e1b6 to
05f1673
Compare
|
Thanks for the PR @danzilio ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the template for
r10k.yamlto use the#to_yamlmethod to generate valid YAML data structures from the data passed to
the template. Previously, we'd print each element assuming there would
be no nested data structures. This PR allows nested data structures to
be passed to
git_settings,forge_settings, anddeploy_settingsparameters.