Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supports for rocketchat #413

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Add supports for rocketchat #413

merged 1 commit into from
Apr 5, 2018

Conversation

amateo
Copy link
Contributor

@amateo amateo commented Mar 16, 2018

In the same way that webhook could send updates to slack, this commit
adds support to send updates to rocketchat.

@amateo
Add supports for rocketchat
6c3adcf 
In the same way that webhook could send updates to slack, this commit
adds support to send updates to rocketchat.
rnelson0
rnelson0 approved these changes Mar 28, 2018
View reviewed changes
Copy link
Member

@rnelson0 rnelson0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not use rocketchat so I cannot test this. The changes look good, just need you to confirm that you have used this module from your branch on git (not a hand-edited copy that may be slightly different) and have no problems before we can merge it.

@amateo
Copy link
Contributor Author

amateo commented Apr 1, 2018

Yes, I'm using it without any problem

@rnelson0 rnelson0 merged commit df718ce into voxpupuli:master Apr 5, 2018
@rnelson0
Copy link
Member

rnelson0 commented Apr 5, 2018

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnelson0 rnelson0 rnelson0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amateo @rnelson0