provide proper default for $r10k_basedir #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchepkov
reviewed
Jul 5, 2018
manifests/params.pp
Outdated
| @@ -10,7 +10,11 @@ | |||
| $sources = undef | |||
| $puppet_master = true | |||
|
|
|||
| $r10k_basedir = $facts['puppet_environmentpath'] | |||
| if $facts['puppet_environmentpath'] { | |||
There was a problem hiding this comment.
helidbe recommends to use different construct :
if 'puppet_environment' in $facts
There was a problem hiding this comment.
@hlindberg is there a technical reason for this? Is it a performance difference? The outcome at the end is the same.
The variable basically contains the value from the puppet_environmentpath fact. The default is /etc/puppetlabs/code/environments. We can safely fallback to the default value if the fact is undef. This allows the module to work properly during the first run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable basically contains the value from the
puppet_environmentpath fact. The default is
/etc/puppetlabs/code/environments. We can safely fallback to the
default value if the fact is undef. This allows the module to work
properly during the first run.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues