Allow uppercase characters in environment names #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like build failures are unrelated to my changes. Can someone refresh the CI to see if it will pass? |
|
This is because the puppetlabs-ruby dependency broke. Fixing in puppetlabs-toy-chest/puppetlabs-ruby#88 |
|
Thanks @baurmatt i'll wait for that PR to get merged and then kick off Travis again. |
|
Kicked off the new build since puppetlabs/ruby has been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Previously the
r10k::deploytask would limit theenvironmentname to a regex that only matched lowercase characters. However,r10kdoes allow for environment names to contain uppercase characters becauser10k deploy environment -pv ABC123_testworks correctly.This PR modifies the regex for the
r10k::deploytask to allow for uppercase characters in environment names.Question: should we also allow for uppercase characters in module names?
This Pull Request (PR) fixes the following issues
n/a