Remove anchor resource from r10k::install::gem
#519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've refactored the class to not use the anchor resource. Since voxpupuli@78283bd#diff-41c34a669409f2dbaa4211d5f642a003L40 it is not being referred to from any other class. If someone needs to create a similar relationship, they can use `Class['r10k::install::gem']` instead.
alexjfisher
commented
Apr 3, 2020
| case $manage_ruby_dependency { | ||
| 'include': { | ||
| include ruby | ||
| include ruby::dev | ||
| Class['::ruby'] | ||
| -> Class['ruby::dev'] |
There was a problem hiding this comment.
Previously, this class needed to become the anchor resource. By requireing it instead, we get the same effect.
ekohl
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored the class to not use the anchor resource.
Since
78283bd#diff-41c34a669409f2dbaa4211d5f642a003L40
it is not being referred to from any other class.
If someone needs to create a similar relationship, they can use
Class['r10k::install::gem']instead.