Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid using deprecated gem options #545

Merged

Conversation

johanfleury
Copy link
Contributor

Pull Request (PR) description

Options --no-ri and --no-rdoc have been deprecated in Ruby 2.6.0 and replaced by --no-document.

This Pull Request (PR) fixes the following issues

Fixes #544.

Copy link
Member

@towo towo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably need to institute a breaking change here, though, for correct versioning.

@johanfleury
Copy link
Contributor Author

Well, --no-documents was introduced in Ruby 2.5 and --no-ri and --no-rdoc was removed in 2.6.

I agree this is a backward incompatible change, but it shoukd only impact very few people.

@cliff-wakefield-acurus
Copy link

Any chance we can progress this please?

@ghoneycutt ghoneycutt requested a review from bastelfreak March 5, 2021 19:23
@ghoneycutt
Copy link
Member

@bastelfreak You want to merge this in with the other backwards-incompatible changes

@bastelfreak bastelfreak merged commit 638b2df into voxpupuli:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI arguments --no-ri and --no-rdoc have been deprecated since Ruby 2.6.0
5 participants