Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make puppetlabs/ruby optional #553

Merged
merged 4 commits into from
May 12, 2021
Merged

Conversation

bastelfreak
Copy link
Member

the puppetlabs/ruby module is deprecated and most people don't use it
anyways. This PR makes the dependency optional.

the puppetlabs/ruby module is deprecated and most people don't use it
anyways. This PR makes the dependency optional.
@bastelfreak
Copy link
Member Author

I pinged RI on slack to get a new release for choria/mcollective

@smortex
Copy link
Member

smortex commented May 12, 2021

👋 @bastelfreak, choria-mcollective-0.13.2 should not be blocking anymore.

@bastelfreak bastelfreak reopened this May 12, 2021
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link

@oranenj oranenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this technically a breaking change? (EDIT: oh, missed the label, there it is.)

Copy link

@anarcat anarcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bastelfreak bastelfreak merged commit 8cdbb6e into voxpupuli:master May 12, 2021
@bastelfreak bastelfreak deleted the ruby branch May 12, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants