-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make puppetlabs/ruby optional #553
Conversation
the puppetlabs/ruby module is deprecated and most people don't use it anyways. This PR makes the dependency optional.
I pinged RI on slack to get a new release for choria/mcollective |
👋 @bastelfreak, choria-mcollective-0.13.2 should not be blocking anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this technically a breaking change? (EDIT: oh, missed the label, there it is.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
the puppetlabs/ruby module is deprecated and most people don't use it
anyways. This PR makes the dependency optional.