Fix mco r10k deploy command in docs to match actual behaviour #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mco r10k` application takes the next arg following the `deploy` action as the environment name to be updated. The example command in the README prefixes the environment name with the `environment` keyword, which causes r10k to be invoked as ```bash r10k deploy environment environment -p ``` instead of the expected environment name. Since the `environment` environment likely does not exist, this renders the `mco r10k deploy` command a noop. Fixes #573
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The
mco r10kapplication takes the next arg following thedeployaction as the environment name to be updated. The example command
in the README prefixes the environment name with the
environmentkeyword, which causes r10k to be invoked as
instead of the expected environment name. Since the
environmentenvironment likely does not exist, this renders the
mco r10k deploycommand a noop.
This Pull Request (PR) fixes the following issues
Fixes #573