pool_size: default to amount of CPU cores #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
bastelfreak-patch-1
branch
from
f85d6a9 to
96a6b30
Compare
rwaffen
reviewed
Jul 5, 2022
| @@ -15,7 +15,7 @@ | |||
| $sources = undef | |||
| $puppet_master = true | |||
| $proxy = undef | |||
| $pool_size = undef | |||
| $pool_size = $facts['processors']['count'] | |||
There was a problem hiding this comment.
often one does cpu.count - 1 to not completely utilize the system.
is this a thing we should consider here to?
There was a problem hiding this comment.
I don't think we need to consider it. My impression is that this is mostly IO bound or limited by the performance forge.puppet.com delivers.
There was a problem hiding this comment.
okay. 👍 just came to my mind when i saw this change 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues