update module to work with webhook-go #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dhollinger
force-pushed
the
replace_webhook
branch
from
3c719b5 to
9654507
Compare
dhollinger
force-pushed
the
replace_webhook
branch
from
9654507 to
cb9b97a
Compare
* Updated params to for the new webhook classes * Created `r10k::webhook` class. This class contains all other classes and parameters. * Added initial tests for os tests.
dhollinger
force-pushed
the
replace_webhook
branch
from
cf98ae5 to
1159f03
Compare
dhollinger
force-pushed
the
replace_webhook
branch
from
1159f03 to
694db29
Compare
bastelfreak
approved these changes
May 31, 2023
dhollinger
commented
May 31, 2023
| systemd: https://github.com/voxpupuli/puppet-systemd.git | ||
| vcsrepo: https://github.com/puppetlabs/puppetlabs-vcsrepo.git | ||
| yumrepo_core: https://github.com/puppetlabs/puppetlabs-yumrepo_core.git | ||
| forge_modules: | ||
| stdlib: | ||
| repo: "puppetlabs/stdlib" | ||
| ref: "8.6.0" |
There was a problem hiding this comment.
puppetlabs/stdlib released 9.0.0 which removes a bunch of deprecated functions. This caused issues with tests in files unrelated to this PR. We will need to address those, but until then, we need to pin the stdlib fixture for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR will contain all the changes necessary to migrate the code over to using
voxpupuli/webhook-gofor the webhook server.This Pull Request (PR) fixes the following issues
R10k::Webhook::ConfigR10k::Webhook::Config::ServerR10k::Webhook::Config::Server::TlsR10k::Webhook::Config::ChatopsR10k::Webhook::Config::R10kmanifests/webhook/config.ppto use the new type aliases forconfig generation. This should map almost 1:1 with the config file
format
repos or other install options yet.