Clean up install class #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install class seems to be designed to make the logic decision on how to install r10k based on whether or not PE is being used. However, some of that logic had leaked out into the init.pp file, and the install/*.pp classes were redundant in many ways. This commit simplifies and reduces the apparent complexity of the class without changing the functional configuration.
There are currently bugs in r10k 1.x which make using 0.x desireable in certain circumstances. However, 0.x requires make and gcc. Conditionally include those classes if necessary due to 0.x r10k version usage. When 1.x is just as good or better than 0.x, we can stop supporting 0.x and remove these bits. Conflicts: manifests/install.pp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install class seems to be designed to make the logic decision on how to install r10k based on whether or not PE is being used. However, some of that logic had leaked out into the init.pp file, and the install/*.pp classes were redundant in many ways. This commit simplifies and reduces the apparent complexity of the class without changing the functional configuration.