[Deprecation] Remove purgedirs support #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trlinkin a few people were at puppetconf, can you update the spec tests and I will get this merged in 3.x of the module. |
As of R10K 1.0.0 the purgedirs functionality and configuration options have been removed. This module continues to configure the no longer acknowledged configuration options. This commit removes support for the purgedirs configuration option.
trlinkin
force-pushed
the
no_more_purgedirs
branch
from
417c4df to
30110d9
Compare
|
@acidprime Ok, hopefully this can make it into 3.0 I rebased against the latest commits and now it passes tests. I could not find any previous tests for purging and since this is a feature remove, I cannot imagine tests to be added. If you can think of tests that need to be added, I'll gladly whip them up. |
acidprime
changed the title
acidprime
added a commit
that referenced
this pull request
May 24, 2015
[Deprecation] Remove purgedirs support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of R10K 1.0.0 the purgedirs functionality and configuration options
have been removed. This module continues to configure the no longer
acknowledged configuration options.
This commit removes support for the purgedirs configuration option.
Oh, also... It should be mentioned that R10K 1.x was released over a year ago now. Reasonably, nobody should be running pre 1.x anymore.