fix test breakage #508
Closed
fix test breakage #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably is no longer needed as the issue has been fixed in puppetlabs/puppetlabs-stdlib#662 and puppetlabs/puppetlabs-stdlib#663 If you do want to test only against stable releases, it might be better/safer to configure |
|
Agreed that this is probably no longer needed now that the bug has been fixed (wasn't sure if it was a bug or intentional behavior) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is intentional, but puppetlabs/puppetlabs-stdlib@970852d
seems to break the acceptance tests. @dhollinger helpfully suggested this fix; if stdlib is not going to be changed in a way that is backwards compatible for tests to at least run, we'll probably need to pin stdlib until the tests can be changed (maybe as part of the 6.0 release?)