Adding note about Puppet 3 support #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
petems
commented
Feb 19, 2017
petems
commented
- Adding deprecation warning
- First steps towards the work in Deprecate Puppet 3.X Support #152
petems
force-pushed
the
add_note_about_puppet_3_eol
branch
from
7271d17 to
3dab108
Compare
ghoneycutt
reviewed
May 3, 2017
README.md
Outdated
| ## Puppet 3 support | ||
|
|
||
| Puppet 3 is EOL as-of January 2017. The last release of this module that will | ||
| support Puppet 3.X and earlier will be 1.2.5 |
There was a problem hiding this comment.
Suggest removing the exact version and just say that the v1 series will support Puppet3 and v2 will support Puppet4.
There was a problem hiding this comment.
Yeah, meant to edit this, was planning on bumping this version to 3.0.0 (so it matches the Puppet version 😄)
Releasing is cheap, and we've done a number of changes to the module we did since the 1.2.X version could possibly be breaking changes, so I thought might as well bump it up 👍
petems
force-pushed
the
add_note_about_puppet_3_eol
branch
2 times, most recently
from
1073060 to
634a23f
Compare
* Adding deprecation warning * First steps towards the work in voxpupuli#152
petems
force-pushed
the
add_note_about_puppet_3_eol
branch
from
634a23f to
363f32d
Compare
cegeka-jenkins
pushed a commit
to cegeka/puppet-redis
that referenced
this pull request
Feb 16, 2021
* Adding deprecation warning * First steps towards the work in voxpupuli#152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.