Fix centos package changes #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upstream CentOS images run slowly on mac * These images have no issues
* First update: spelling tweaks and description updates. No functionality change in Puppet erb
* Having the group as redis causes issues on CentOS 6 machines
* We're changing some of the default configurations from the upstream packages * This causes issues with CentOS 6 services, and needlessly clutters logs. * Change to follow ownership patterns of original packages
|
// , This pull request has a lot going on. I'm not sure why it's failing checks, though. Is it because of this error? Anyway, I guess I'm mostly interested in Did you start out with https://raw.githubusercontent.com/antirez/redis/3.2/redis.conf, and add in this module's parameterized values, or start out with our current .erb file and add in some of the extra content from https://raw.githubusercontent.com/antirez/redis/3.2/redis.conf ? |
|
This is a grab-bag PR to see what sticks, I'm pulling out the individual parts into other PR's to get the whole thing working (see #162 for example) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.