Add switch to manage File[/var/run/redis] #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petems
force-pushed
the
ntnn-fix/debian-runtime-dir
branch
3 times, most recently
from
1827691 to
9ebf92d
Compare
* The existence of /var/run/redis causes the startup of redis-server via
systemd to fail on debian systems with redis-server >= 3.2.8-2:
```
May 18 19:17:54 debian-8 systemd[1]: Starting Advanced key-value store...
May 18 19:17:54 debian-8 systemd[803]: Failed at step RUNTIME_DIRECTORY spawning /bin/run-parts: File exists
May 18 19:17:54 debian-8 systemd[804]: Failed at step RUNTIME_DIRECTORY spawning /usr/bin/redis-server: File exists
May 18 19:17:54 debian-8 systemd[1]: redis-server.service: control process exited, code=exited status=233
May 18 19:17:54 debian-8 systemd[1]: Failed to start Advanced key-value store.
May 18 19:17:54 debian-8 systemd[1]: Unit redis-server.service entered failed state.
May 18 19:17:54 debian-8 systemd[1]: redis-server.service holdoff time over, scheduling restart.
```
* It will actually eventually start, but the first run will fail
* The default unit file for redis-server in debian jessie-backports
contains `RuntimeDirectory=redis`, see [this commit](https://github.com/lamby/pkg-redis/commit/1cecea5abcb2ce05beacd4347977634d06c59cef).
* Adds logic to not manage the /var/run/redis directory if systemd present
petems
force-pushed
the
ntnn-fix/debian-runtime-dir
branch
from
9ebf92d to
8ed64aa
Compare
cegeka-jenkins
pushed a commit
to cegeka/puppet-redis
that referenced
this pull request
Feb 16, 2021
* The existence of /var/run/redis causes the startup of redis-server via
systemd to fail on debian systems with redis-server >= 3.2.8-2:
```
May 18 19:17:54 debian-8 systemd[1]: Starting Advanced key-value store...
May 18 19:17:54 debian-8 systemd[803]: Failed at step RUNTIME_DIRECTORY spawning /bin/run-parts: File exists
May 18 19:17:54 debian-8 systemd[804]: Failed at step RUNTIME_DIRECTORY spawning /usr/bin/redis-server: File exists
May 18 19:17:54 debian-8 systemd[1]: redis-server.service: control process exited, code=exited status=233
May 18 19:17:54 debian-8 systemd[1]: Failed to start Advanced key-value store.
May 18 19:17:54 debian-8 systemd[1]: Unit redis-server.service entered failed state.
May 18 19:17:54 debian-8 systemd[1]: redis-server.service holdoff time over, scheduling restart.
```
* It will actually eventually start, but the first run will fail
* The default unit file for redis-server in debian jessie-backports
contains `RuntimeDirectory=redis`, see [this commit](https://github.com/lamby/pkg-redis/commit/1cecea5abcb2ce05beacd4347977634d06c59cef).
* Adds logic to not manage the /var/run/redis directory if systemd present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existence of /var/run/redis causes the startup of redis-server via
systemd to fail on debian systems with redis-server >= 3.2.8-2.
The default unit file for redis-server in debian jessie-backports
contains
RuntimeDirectory=redis, see this commit.This causes systemd to attempt to create
/var/run/redis, which fails,since puppet already created it:
Additionally the
$var_run_redis_modeis wrong as well, since redis-serversets it to
0755and the module changes it back to2755.Also see issue #150, the same applies here - puppet changes the mode of
/var/run/dirand refreshesService[redis-server], which then failsto restart because systemd can't create the directory.