Refactor redisget() method #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
petems
commented
Jun 22, 2017
petems
commented
- The original behaviour seemed a little brittle to me, so I asked for some help
- This new refactor seems a lot cleaner, and deals with the handling of getting a nil response a lot cleaner
- Specs edited to add in two types of disconnection errors: getaddrinfo for non-existent DNS and ECONNREFUSED for when connection refused
- Credit: https://codereview.stackexchange.com/questions/163727/redis-lookup-with-a-default-value/
|
@ghoneycutt can you check this change doesn't break your redisget() behaviour? |
ghoneycutt
reviewed
Jun 22, 2017
spec/functions/redisget_spec.rb
Outdated
| context 'should error if connection to redis server cannot be made and no default is specified' do | ||
| it { is_expected.to run.with_params('nonexistent_key', BROKEN_URL).and_raise_error(Puppet::Error, /connection to redis server failed - getaddrinfo/) } | ||
| context 'should error if connection to remote redis server cannot be made and no default is specified' do | ||
| it { is_expected.to run.with_params('nonexistent_key', REMOTE_BROKEN_URL).and_raise_error(Puppet::Error, 'connection to redis server failed - getaddrinfo: nodename nor servname provided, or not known') } |
There was a problem hiding this comment.
change to regex to appease different versions of puppet/ruby
/connection to redis server failed/
|
I'll give this a go today. |
|
Tested the functionality and works as expected. |
petems
force-pushed
the
use_redisget_refactor
branch
from
d098506 to
42c9788
Compare
* The original behaviour seemed a little brittle to me, so I asked for some help * This new refactor seems a lot cleaner, and deals with the handling of getting a nil response a lot cleaner * Specs edited to add in two types of disconnection errors: getaddrinfo for non-existent DNS and ECONNREFUSED for when connection refused * Credit: https://codereview.stackexchange.com/questions/163727/redis-lookup-with-a-default-value/
petems
force-pushed
the
use_redisget_refactor
branch
from
42c9788 to
3d625e4
Compare
cegeka-jenkins
pushed a commit
to cegeka/puppet-redis
that referenced
this pull request
Feb 16, 2021
* The original behaviour seemed a little brittle to me, so I asked for some help * This new refactor seems a lot cleaner, and deals with the handling of getting a nil response a lot cleaner * Specs edited to add in two types of disconnection errors: getaddrinfo for non-existent DNS and ECONNREFUSED for when connection refused * Credit: https://codereview.stackexchange.com/questions/163727/redis-lookup-with-a-default-value/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.