Use package_ensure if it specifies a version instead of the minimum_version #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sp-joseluis-ledesma
force-pushed
the
master
branch
from
360ac5b to
3989f1a
Compare
|
Ah, good point, didn't think of that usecase! Let me review this 😄 |
petems
reviewed
Jul 11, 2017
manifests/instance.pp
Outdated
| @@ -276,7 +277,11 @@ | |||
| refreshonly => true, | |||
| } | |||
|
|
|||
| $redis_version_real = pick(getvar_emptystring('redis_server_version'), $minimum_version) | |||
| if $package_ensure =~ /^[0-9]\.[0-9]/ { | |||
There was a problem hiding this comment.
Hmm, we might want to extend this regex. If someone's using an rc/alpha candidate this regex won't match (eg. https://github.com/antirez/redis/archive/4.0-rc3.tar.gz)
Can we extend the regex and add some extra usecases to the specs? eg. 3 digits (3.2.1), non-numeric characters (4.0.0-rc)
There was a problem hiding this comment.
The regex matches (I did not look for the end of the regex, only start with [0-9].[0-9]). Anyway I've improved it a bit (/^[0-9]+.[0-9]/) so it will work when redis get to version 10 :).
I've added a couple more of specs usecases.
sp-joseluis-ledesma
force-pushed
the
master
branch
from
3989f1a to
14c762f
Compare
|
Awesome, LGTM! 😄 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-redis
that referenced
this pull request
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using package_ensure => some_version, it will initially configure the the redis using the minimum_version variable anyway instead of taking in account the package_ensure variable. This PR fixes that.