Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protected-mode configuration option (Redis 3.2+) #243

Merged
merged 2 commits into from
Oct 16, 2017

Conversation

Dan70402
Copy link
Contributor

@Dan70402 Dan70402 commented Oct 9, 2017

This allows one to bypass the protected-mode on Redis 3.2+ when listening on all interfaces.

@petems
Copy link
Member

petems commented Oct 9, 2017

@Dan70402 Awesome, if thise goes green I'll merge 👍

@Dan70402
Copy link
Contributor Author

Dan70402 commented Oct 9, 2017

This was a little more involved than I had first thought. I found #163 which had some discussion on the best way to manage various breaking changes in the redis configs. Based on the comments and the existing pattern I implemented the protected-mode mode for 3.2. This will only add the protected-mode for 3.2 versions of redis because of the existing string based switch for selecting the redis erb to use. It should be straight forward to add additional 3.2 configuration if anyone would like.

@petems petems merged commit 6c28bc3 into voxpupuli:master Oct 16, 2017
@Dan70402 Dan70402 deleted the protected-mode-config branch October 20, 2017 16:01
cegeka-jenkins pushed a commit to cegeka/puppet-redis that referenced this pull request Feb 16, 2021
* protected-mode configuration option (Redis 3.2+)

* Redis 3.2 basic new config support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants