Adds logic for installing redid-sentinel package #254
Conversation
manifests/sentinel.pp
Outdated
| # See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775414 for context | ||
| if (versioncmp($::operatingsystemmajrelease, '16.04') >= 0 or $::redis::manage_repo) { | ||
| if ( | ||
| versioncmp($::operatingsystemmajrelease, '16.04') >= 0 or |
There was a problem hiding this comment.
This should also include something like $::operatingsystem == "ubuntu" and below the same for "debian".
There was a problem hiding this comment.
... and still I think the condition should go to params.pp. This way it is still broken for debian-jessie and older, as the require => Package[$package_name]; some lines later will fail otherwise.
There was a problem hiding this comment.
Good point, the edgecase is unlikely (Ubuntu on 9 or earlier) but might as well protect against it
There was a problem hiding this comment.
The require package name works fine, because on Jessie the package is redis instead of redis-sentinel. The tests work, both unit and acceptance 👍
petems
force-pushed
the
update_debian_package_for_sentinel
branch
from
50ad996 to
21ed840
Compare
spec/classes/redis_sentinel_spec.rb
Outdated
| @@ -87,4 +87,26 @@ | |||
| } | |||
| end | |||
|
|
|||
| describe 'on Debian Stretch' do | |||
There was a problem hiding this comment.
This should probably be "on Debian Jessie".
* Debian Stretch also added a separate package also: https://packages.debian.org/stretch/redis-sentinel * Closes #253
petems
force-pushed
the
update_debian_package_for_sentinel
branch
from
21ed840 to
7c0e40c
Compare
* Debian Stretch also added a separate package also: https://packages.debian.org/stretch/redis-sentinel * Closes voxpupuli#253
also: https://packages.debian.org/stretch/redis-sentinel