Support instances inside Hiera #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
requested changes
Nov 15, 2019
Switch to using *.each from create_resources
alexjfisher
requested changes
Nov 15, 2019
bastelfreak
reviewed
Nov 16, 2019
manifests/init.pp
Outdated
| @@ -252,14 +252,21 @@ | |||
| $cluster_node_timeout = $redis::params::cluster_node_timeout, | |||
| Integer[0] $cluster_slave_validity_factor = $redis::params::cluster_slave_validity_factor, | |||
| Boolean $cluster_require_full_coverage = $redis::params::cluster_require_full_coverage, | |||
| Integer[0] $cluster_migration_barrier = $redis::params::cluster_migration_barrier | |||
| Integer[0] $cluster_migration_barrier = $redis::params::cluster_migration_barrier, | |||
| Hash $instances = {}, | |||
There was a problem hiding this comment.
Could you update the datatype?
Suggested change
| Hash $instances = {}, | |
| Hash[String[1], Hash] $instances = {}, |
This should be valid
cegeka-jenkins
pushed a commit
to cegeka/puppet-redis
that referenced
this pull request
Feb 16, 2021
* Add feature to use instances in hiera * revert * try again * Missing this * remove whitespace * Add Hash * replace with each * add arguments * insert values into loop iteration * mis-aligned * soft tabs * remove comment - not relevant to all * Update hash type * Add comment/notes * Add short description ::instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
#329