Adding ability to secure Sentinel #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct config_dir for scl support
|
Failed test does not look to be related to the Code. |
bastelfreak
reviewed
Apr 27, 2021
|
thanks for the PR! can you pleae add a unit test for this? |
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
|
@bastelfreak Note that CI check for Puppet 5 - Ubuntu 20.04 is failing in all PRs because there are no Puppet 5 packages in apt.puppetlabs.com for Ubuntu 20.4 (Puppet 5 is not supported for Ubuntu 20.4, see https://puppet.com/docs/puppet/5.5/system_requirements.html#platforms-with-packages). Could this check be eliminated? |
|
Any hope this could be merged @bastelfreak ? |
cegeka-jenkins
pushed a commit
to cegeka/puppet-redis
that referenced
this pull request
Feb 15, 2022
Adding ability to secure Sentinel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Sentinel instances themselves can be secured by requiring clients to authenticate via the AUTH command. Starting with Redis 6.2, the Access Control List (ACL) is available, whereas previous versions (starting with Redis 5.0.1) support password-only authentication. This PR introduces the password-only authentication available from Redis 5.0.1 onwards.
https://redis.io/topics/sentinel#sentinel-password-only-authentication
This Pull Request (PR) fixes the following issues
Fixes #305