Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Puppet-Datatype Sensitive for $masterauth and $auth_pass #403

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Use Puppet-Datatype Sensitive for $masterauth and $auth_pass #403

merged 1 commit into from
Jul 27, 2021

Conversation

cocker-cc
Copy link
Contributor

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@kenyon kenyon changed the title Use Puppet-Datatype Sensitive Use Puppet-Datatype Sensitive for $masterauth and $auth_pass Jun 17, 2021
@kenyon kenyon added the enhancement New feature or request label Jun 17, 2021
@ekohl
Copy link
Member

ekohl commented Jul 16, 2021

Looks like there's a merge conflict now. Would you mind rebasing?

@cocker-cc
Copy link
Contributor Author

Looks like there's a merge conflict now. Would you mind rebasing?

Done.

ekohl
ekohl reviewed Jul 19, 2021
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also set show_diff on the file resource if the value was passed in as Sensitive? I think something like this should work:

file { '...':
  show_diff => $var !~ Sensitive,
}

manifests/init.pp Outdated Show resolved Hide resolved
@cocker-cc
Copy link
Contributor Author

Should we also set show_diff on the file resource if the value was passed in as Sensitive? I think something like this should work:

file { '...':
  show_diff => $var !~ Sensitive,
}

With EPP instead of ERB the file-Resource would behave automatically. I created this PR for therefor.

@ekohl
Copy link
Member

ekohl commented Jul 22, 2021

Needs a rebase now that that PR is merged.

@cocker-cc
Copy link
Contributor Author

rebase

Done.

@ekohl ekohl merged commit 8d46164 into voxpupuli:master Jul 27, 2021
@ekohl
Copy link
Member

ekohl commented Jul 27, 2021

Thanks!

cegeka-jenkins pushed a commit to cegeka/puppet-redis that referenced this pull request Feb 15, 2022
@ekohl
Merge pull request voxpupuli#403 from cocker-cc/Use_Puppet-Datatype_S…
2a7cd00 
…ensitive

Use Puppet-Datatype Sensitive for $masterauth and $auth_pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@kenyon kenyon kenyon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cocker-cc @ekohl @kenyon