Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: tags to fix aclpolicy #265

Merged
merged 1 commit into from
Oct 10, 2016
Merged

Conversation

zlanyi
Copy link
Contributor

@zlanyi zlanyi commented Sep 21, 2016

No description provided.

@zlanyi zlanyi changed the title add: tags to fix aclpolicy add: tags to fix aclpolicy and fix Rakefile Sep 21, 2016
@alexjfisher
Copy link
Member

@zlanyi Thanks for your PR. Sorry you bumped into the puppet-strings issue before it was fixed in master.

Fixing by updating the Rakefile was considered, but in the end we went with pinning puppet-strings to the last release instead. The fix is now in this module via the latest modulesync

You were also unfortunate with the timing of your last push! Your build has failed due to puppetlabs/stdlib having been broken for a few hours earlier.

If you rebase against the current master, you should be able to drop your Rakefile commit and your build should now go green.

As for 49b0184 itself, it seems simple enough, but I'm not a rundeck expert! I can merge it if you could explain it a bit, or perhaps provide a link to some docs?

@zlanyi zlanyi changed the title add: tags to fix aclpolicy and fix Rakefile add: tags to fix aclpolicy Sep 22, 2016
@jyaworski jyaworski merged commit 3a4ac63 into voxpupuli:master Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants