Replace ensure_resource with base class and add package_source parameter
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By having a base class that can be included by multiple instances of `spiped::tunnel`, we can remove the use of `ensure_resource`. This also makes it possible to provide parameters via the base class. I've added `package_source`. This parameter can be used on OSes that don't ship a `spiped` package. This commit also contains new rspec-puppet tests and a README update explaining how to use the module on RedHat family systems.
bastelfreak
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having a base class that can be included by multiple instances of
spiped::tunnel, we can remove the use ofensure_resource.This also makes it possible to provide parameters via the base class.
I've added
package_source. This parameter can be used on OSes thatdon't ship a
spipedpackage.This commit also contains new rspec-puppet tests and a README update
explaining how to use the module on RedHat family systems.