Replace source and dest parameters
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
force-pushed
the
source_target
branch
3 times, most recently
from
2cf20dd
to
1354935
Compare
Split `source` parameter into `source_socket_file`, `source_host` and `source_port` parameters. Rename `dest` parameter to `target_` parameters. By splitting the parameters, it's much easier to do proper input validation and build the socket parameters passed to the binary correctly. For instance, IP addresses are supposed to be surrounded by square brackets but hostnames should not. See https://github.com/Tarsnap/spiped/blob/5c13832aeecdad8a655dadcf5413cc504ad99e49/libcperciva/util/sock.c#L253 Replace erb with epp template.
alexjfisher
force-pushed
the
source_target
branch
from
1354935
to
43cb3db
Compare
alexjfisher
changed the title
source and dest parameterssource and dest parameters
bastelfreak
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
sourceparameter intosource_socket_file,source_hostandsource_portparameters. Renamedestparameter totarget_parameters.
By splitting the parameters, it's much easier to do proper input
validation and build the socket parameters passed to the binary
correctly. For instance, IP addresses are supposed to be surrounded by
square brackets but hostnames should not.
See https://github.com/Tarsnap/spiped/blob/5c13832aeecdad8a655dadcf5413cc504ad99e49/libcperciva/util/sock.c#L253
Replace erb with epp template.