Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.2.0 Release #139

Merged
merged 1 commit into from
Sep 24, 2017
Merged

6.2.0 Release #139

merged 1 commit into from
Sep 24, 2017

Conversation

TraGicCode
Copy link
Contributor

@TraGicCode TraGicCode commented Sep 24, 2017 •
edited
Loading

Cutting new release. Did a bump on the minor since the public API didn't change and i simply updated a dependency.

@TraGicCode TraGicCode requested a review from wyardley September 24, 2017 03:30
wyardley
wyardley reviewed Sep 24, 2017
View reviewed changes
Copy link
Contributor

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not bumping the version is probably Ok, but I think we need to at least flag the switch to archive as backwards-incompatible, and update the title of the PR to have 'BREAKING' in front.

@TraGicCode
Copy link
Contributor Author

TraGicCode commented Sep 24, 2017 •
edited
Loading

There has to be a bump somewhere in the version in order to follow semver. Also I was basing the non-breaking change off the recommendation in the semver doc.

image

@wyardley wyardley merged commit eab1757 into voxpupuli:master Sep 24, 2017
@TraGicCode TraGicCode deleted the cut_release branch September 24, 2017 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyardley wyardley wyardley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TraGicCode @wyardley