Make splunk_user configurable. #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Sep 5, 2018
manifests/params.pp
Outdated
| @@ -86,6 +89,10 @@ | |||
| $server = 'splunk', | |||
| $forwarder_installdir = undef, | |||
| $server_installdir = undef, | |||
| $splunk_user = $::osfamily ? { | |||
There was a problem hiding this comment.
can you please use facts$['os']['family'] as fact here? The old toplevel variables are deprecated.
bastelfreak
added
enhancement
|
👍 |
|
Can you take a look at the failing spec tests? |
|
It looks like it simply couldn't do the lookup in parameters list because |
|
thanks! |
|
No problem! I really appreciate all the work y'all have put into this module. It's very helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Pull Request (PR) description
This PR addresses #159 without making any backwards-incompatible changes. I would like to be able to configure the Splunk user but have no opinion I wish to assert over what should be the default for this module. There are certainly best-practices from Splunk that advise running as
splunk, but the default for a long time was to run asAdministratororroot, as configured here by default. In 2018, this is no longer the case. However, I could totally see environments with extreme change control processes that MUST maintain current configs (and have likely implemented compensating controls to protect against the fact that Splunk has higher privilege than necessary).All that said, I think enabling folks to make the call for their own environment is the best path forward and would appreciate your consideration!