Add splunkforwarder_version fact

[treydock]

Adds splunkfowarder_version fact that works for both Linux and Windows.

[treydock]

Should change to spec_helper be made to module_sync repo?

[treydock]

Can't get this to work on Windows and my Windows knowledge is very limited. I've added this debug at top of fact:

Facter.debug("EXISTS: #{File.exist?('C:/')}")
Facter.debug("EXISTS: #{File.exist?('C:/Program Files')}")
Facter.debug("EXISTS: #{File.exist?('C:/Program Files/SplunkUniveralForwarder')}")
Facter.debug("EXISTS: #{File.exist?('C:/Program Files/SplunkUniveralForwarder/bin')}")
Facter.debug("EXISTS: #{File.exist?('C:/Program Files/SplunkUniveralForwarder/bin/splunk.exe')}")

The result is this:

2018-10-29 12:04:19.884098 DEBUG puppetlabs.facter - EXISTS: true
2018-10-29 12:04:19.884098 DEBUG puppetlabs.facter - EXISTS: true
2018-10-29 12:04:19.884098 DEBUG puppetlabs.facter - EXISTS: false
2018-10-29 12:04:19.884098 DEBUG puppetlabs.facter - EXISTS: false
2018-10-29 12:04:19.884098 DEBUG puppetlabs.facter - EXISTS: false

For some reason I can't see C:\Program Files\SplunkUniversalForwarder but when I run those commands via irb the result is true.

[treydock]

Arg. Fixed, I was spelling Universal wrong.

[treydock]

[root@puppet0 ~]# facter -p splunkforwarder_version
6.5.2

C:\Windows\system32>facter -p splunkforwarder_version
7.0.2

[alexjfisher]

Should change to spec_helper be made to module_sync repo?

modulesync_config already supports this. You need the following in .sync.yml.

spec/spec_helper.rb:
  mock_with: :rspec

eg
https://github.com/voxpupuli/puppet-mongodb/blob/2aef85553d4a7e8b67386ba81a650a9c8dec288c/.sync.yml#L9-L10

[treydock]

Moved the spec_helper change to separate commit and added the necessary update to .sync.yml

[bastelfreak]

@alexjfisher can you recheck? I'm fine with it.

[alexjfisher]

@treydock Thanks!