Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config items are collected with tag - make sure it exists #25

Merged
merged 2 commits into from
Feb 25, 2016

Conversation

asquelt
Copy link
Contributor

@asquelt asquelt commented Sep 14, 2015

splunk_forwarder tag is used for dependency setting (package, service), so it's essential all configuration items created by splunk::forwarder class contains those tags (unless user deliberately decides to override them).

asquelt added 2 commits September 14, 2015 11:12
splunk_forwarder tag is used for dependency setting (package, service),
so it's essential all configuration items created by splunk::forwarder
class contains those tags (unless user deliberately decides to override
them).
@hunner
Copy link
Member

hunner commented Feb 25, 2016

Instead of adding tags to the create_resources of splunk_forwarder could you just change the collectors <| tag == 'splunk_forwarder' |> below to <| tag == 'splunk::forwarder' |>

@hunner
Copy link
Member

hunner commented Feb 25, 2016

Actually, this is probably fine as-is

hunner added a commit that referenced this pull request Feb 25, 2016
config items are collected with tag - make sure it exists
@hunner hunner merged commit 2935b79 into voxpupuli:master Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants