Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add secret_file parameter to Windows #254

Merged
merged 1 commit into from
Sep 24, 2019
Merged

add secret_file parameter to Windows #254

merged 1 commit into from
Sep 24, 2019

Conversation

kreeuwijk
Copy link
Contributor

Pull Request (PR) description

adds the secret_file parameter to Windows

This Pull Request (PR) fixes the following issues

the secret_file parameter was missing for the Windows case in params.pp which was causing a catalog compilation failure with the following error:

Error while evaluating a Resource Statement, Class[Splunk::Forwarder]: parameter 'secret_file' expects a Stdlib::Absolutepath = Variant[Stdlib::Windowspath = Pattern[/^(([a-zA-Z]:[\\\/])|([\\\/][\\\/][^\\\/]+[\\\/][^\\\/]+)|([\\\/][\\\/]\?[\\\/][^\\\/]+))/], Stdlib::Unixpath = Pattern[/^\/([^\/\0]+\/*)*$/]] value, got Undef

@kreeuwijk
Copy link
Contributor Author

The Debian tests on Travis are failing, it seems those tests aren't fully updated for the seed_password update. It has nothing to do with this PR.

@ody
Copy link
Contributor

ody commented Sep 24, 2019

I am going to go ahead and merge this, I've validated that the PR has nothing to do with the failing tests. Different platform combinations failed on re-run of the build and I've only been able to get them to pass locally so I'll handle figuring out the tests that seem to have come from one of my previous PRs

@ody ody merged commit 77ddd9b into voxpupuli:master Sep 24, 2019
@ody ody mentioned this pull request Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants