added technology addon feature #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to see some spec tests here, ensuring there is code coverage and things work as expected. |
| # } | ||
| # } | ||
| # | ||
| define splunk::ta ( |
There was a problem hiding this comment.
Would this be easier understood if it was named splunk::addon or something? "ta" isn't something I would know without reading docs.
There was a problem hiding this comment.
Or splunk::app since it goes in the apps directory?
There was a problem hiding this comment.
|
Thanks for this! I think we don't require tests because there are none for the module at all, but if you could address my review comments that would be great! |
* splunk::ta renamed to splunk::addon * splunk::addon::input marked as private * template syntax clean up * concat for addon input made conditional to prevent blank file
|
@hunner thanks for looking this PR over... I agree with your points and I've modified the PR with a second commit that covers these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The splunk module has no support for configuring forwarders for TA's (technology addons) which, according to the docs, have their input forwarders configured in $SPLUNK_HOME/etc/apps//local/inputs.conf
I'm using a fork of this module to be able to have this feature - it currently only supports configuring inputs and installing packages for TA's but other local config could be added in the same model.
Would like to merge this to keep the upstream updated.