-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to override default-host configuration #279
Add ability to override default-host configuration #279
Conversation
I don't really see how these test failures could be related to my change? Please let me know if I'm missing something. Cheers! |
@bastelfreak since you seem to be the most active maintainer would you mind reviewing this PR if you have a minute free? Thanks. |
@ghoneycutt perhaps you could take a look at this if you have a moment? |
Dear @dave-pollock, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
@dave-pollock can you please rebase this against our latest master? The git history is a bit clumsy at the moment. |
@bastelfreak I've rebased. |
Pull Request (PR) description
Add ability to override default-host configuration. The default-host configuration is used to control the "host" property which Splunk will use to identify the forwarder. The current behaviour forces the default-host to match the server's $HOSTNAME. In my environment we prefer to customise this name to identify the region and environment for the forwarder (info we don't normally include in the server's hostname).
The default behaviour is maintained so this shouldn't break any existing setup. It just adds the ability to override it if required.
This Pull Request (PR) fixes the following issues
N/A