forwarder::pkg_provider should default to $splunk::params::pkg_provider

[hunner]

Closes #21

[hunner]

This is backwards-incompatible

[hunner]

The base class defaults to using $splunk::params::pkg_provider as the chosen package provider but the splunk::forwarder define defaults to undef for the provider. This commit now syncronizes the behavior to be consistent between both items.

[hunner]

@asquelt @kyledecot Does this look appropriate to you? Would this be considered a "bug fix" because the behavior of the module was inconsistent? (re #21)

[Ziaunys]

This should be $splunk::params::pkg_provider, right? Once this is fixed it should be ready to merge. I encountered this issue as well. The temporary fix is explicitly setting pkg_provider the the splunk::forwarder class to 'rpm' so when this is merged users can expect to see that as the default.

[discreet]

I've had to change the code to implement this fix. Will this be updated and merged soon? Seems like it just needs a very simple minor change to the PR.

[hunner]

Updated, and calling this a bugfix instead of backwards-incompatible feature as the intent (as shown in the base class) is to follow splunk::params::pkg_provider and this failed to follow the original intent.