Allow user-seed.conf to set a username besides 'admin' #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Sep 21, 2021
| [user_info] | ||
| USERNAME=admin | ||
| USERNAME=<%= $user %> |
There was a problem hiding this comment.
thanks for the PR, can you please add a unit test for this change?
There was a problem hiding this comment.
The class had no test at all, so I kinda winged it, but, "added."
I didn't write much of this, and I'm not a great test writer, but, here goes.
|
thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Allow
user-seed.confto have a not-hardcoded userid instead of 'admin.This Pull Request (PR) fixes the following issues
The
user-seed.conffile sets a default local user/password (admin/changeme by default). Some security policies wish for you to have only non-default userids. At present, the existing module doesn't allow that.The testing is a little lax here because there was not great testing on these classes to begin with. Sorry.